fix: don't download hadolint twice #135
Conversation
|
Thanks a lot for the effort. Almost there! |
SMoraisAnsys
force-pushed
the
fix/multiple_calls
branch
from
9725b21 to
d77d78d
Compare
|
Hi @jbergstroem, is there a chance that this PR gets accepted next week with a following new release ? If there is something that is missing, feel free to point it out :) |
Was AFK this weekend but yeah it'll land in 24h |
jbergstroem
changed the title
|
Hi @jbergstroem, sorry to be so insistent but I'd really like to be able to use these developments through your action. Would it be possible to have a release this week? |
Apologise for the delay; took the opportunity to refactor the install into its own shell script. I'm almost done. |
|
@SMoraisAnsys ok, I think we're in good shape. How does it look for you? |
When running the action twice in a job, it fails because the directory we tried to create already exists. Check if there already is a binary and that it is the version we expect. This also saves us a bit of time by avoiding a re-download. Finally, add e2e tests to cover all use-cases. PR: jbergstroem#135 Closes: jbergstroem#134 Co-Authored-By: Johan Bergström <[email protected]>
jbergstroem
force-pushed
the
fix/multiple_calls
branch
from
44b220d to
b0e99c7
Compare
When running the action twice in a job, it fails because the directory we tried to create already exists. Check if there already is a binary and that it is the version we expect. This also saves us a bit of time by avoiding a re-download. Finally, add e2e tests to cover all use-cases. PR: jbergstroem#135 Closes: jbergstroem#134 Co-Authored-By: Johan Bergström <[email protected]>
jbergstroem
force-pushed
the
fix/multiple_calls
branch
from
b0e99c7 to
3589f51
Compare
|
Yeah, everything look fine. Thanks for your help and great job with the refactoring ! |
Note: this is now possible since jbergstroem/hadolint-gh-action#135 got merged and released.
Note: this is now possible since jbergstroem/hadolint-gh-action#135 got merged and released.
Problem
When one wants to use hadolint-gh-action multiple times, an error is raised because the bin directory already exists, see #134
Solution
Use option -p of mkdir
Fixes #134